Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress clang undefined behavior sanitizer in EnvmapAttribute::copyValuesFrom() #806

Merged
merged 2 commits into from
Aug 7, 2020
Merged

suppress clang undefined behavior sanitizer in EnvmapAttribute::copyValuesFrom() #806

merged 2 commits into from
Aug 7, 2020

Conversation

peterhillman
Copy link
Contributor

No description provided.

@peterhillman
allow undefined EnvMap enum values for future proofing
92ec98d 
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
@peterhillman
suppress clang undefined behavior sanitizer in EnvmapAttribute::copyV…
cd28842 
…aluesFrom()

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
cary-ilm approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm cary-ilm merged commit 1a3f3f6 into AcademySoftwareFoundation:master Aug 7, 2020
@peterhillman peterhillman mentioned this pull request Aug 18, 2020
Merged
@peterhillman peterhillman deleted the envmapenum branch September 30, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cary-ilm cary-ilm cary-ilm approved these changes

Assignees
No one assigned
Labels
v2.5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterhillman @cary-ilm